*: replace gofail with the new failpoint implementation #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
lonng
changed the title
winkyao
reviewed
Apr 20, 2019
|
LGTM |
Signed-off-by: Lonng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10184 +/- ##
================================================
- Coverage 77.9586% 77.9576% -0.0011%
================================================
Files 407 407
Lines 83171 83285 +114
================================================
+ Hits 64839 64927 +88
- Misses 13528 13551 +23
- Partials 4804 4807 +3 |
|
/run-all-tests |
|
Please introduce to PD. |
|
do we need to use in go-client? |
|
@siddontang No plan now. The current intend is based on mock-tikv to inject errors. |
zz-jason
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng [email protected]
What problem does this PR solve?
Replace gofail with the new failpoint implementation failpoint
What is changed and how it works?
Replace all dependencies and failpoints trigger condition.
Check List
Tests
Code changes
Side effects
Related changes