planner: correct estimated row count for inner plan of index join #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
zz-jason
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #10015 +/- ##
===============================================
+ Coverage 77.7034% 77.7044% +0.001%
===============================================
Files 403 403
Lines 81878 81873 -5
===============================================
- Hits 63622 63619 -3
+ Misses 13558 13557 -1
+ Partials 4698 4697 -1 |
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Apr 4, 2019
zz-jason
pushed a commit
that referenced
this pull request
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For index join, if inner plan is table scan, i.e, handle is index join key, and if there is selection above table scan, the estimated row count is wrong. This should has no impact on the final plan chosen, but the explain output is confusing, so I fix it.
What is changed and how it works?
Use stats of table scan instead of datasource as the stats of selection.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes