Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not use INSERT IGNORE INTO in lightning tables #57578

Closed
joechenrh opened this issue Nov 21, 2024 · 1 comment · Fixed by #57577
Closed

Should not use INSERT IGNORE INTO in lightning tables #57578

joechenrh opened this issue Nov 21, 2024 · 1 comment · Fixed by #57577
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/inconsistency incorrect/inconsistency/inconsistent severity/moderate type/bug The issue is confirmed as a bug.

Comments

@joechenrh
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

#55477 changes INSERT INTO to `INSERT IGNORE INTO, which may case data correctness.

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@joechenrh joechenrh added the type/bug The issue is confirmed as a bug. label Nov 21, 2024
@joechenrh joechenrh mentioned this issue Nov 21, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 21, 2024
@joechenrh
Copy link
Contributor Author

/severity moderate

@ti-chi-bot ti-chi-bot bot closed this as completed in 039b386 Nov 21, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Nov 21, 2024
Merged
13 tasks
@jebter jebter added the impact/inconsistency incorrect/inconsistency/inconsistent label Nov 22, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 22, 2024
@ti-chi-bot
lightning: remove some NOT NULL constraints on lightning table (#57577
c257fbe 
) (#57600)

close #57578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/inconsistency incorrect/inconsistency/inconsistent severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: remove some NOT NULL constraints on lightning table joechenrh/tidb
2 participants
@jebter @joechenrh