Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR: Add Verision Checking for Migrations #57540

Closed
Tracked by #56522
YuJuncen opened this issue Nov 20, 2024 · 0 comments · Fixed by #57541
Closed
Tracked by #56522

BR: Add Verision Checking for Migrations #57540

YuJuncen opened this issue Nov 20, 2024 · 0 comments · Fixed by #57541
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.

Comments

@YuJuncen
Copy link
Contributor

Enhancement

For now, the message Migration isn't versioned. That means, when a older version of BR tries to merge higher version of migrations, it cannot detect the newly added fields. Then it will drop those fields and consequently cause metadata corruption. We need check the version before loading a Migration from storage.
@YuJuncen YuJuncen added the type/enhancement The issue or PR belongs to an enhancement. label Nov 20, 2024
@YuJuncen YuJuncen mentioned this issue Nov 20, 2024
Merged
13 tasks
@YuJuncen YuJuncen added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 20, 2024
@YuJuncen YuJuncen mentioned this issue Nov 20, 2024
Open
17 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 21, 2024
@YuJuncen
br/stream: Added Version Check for Loading Migrations. (#57541)
91c14a4 
close #57540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br/stream: Added Version Check for Loading Migrations. YuJuncen/tidb
1 participant
@YuJuncen