Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: ebs backup progress uses # of stores, not # of volumes, to track progress #54555

Closed
michaelmdeng opened this issue Jul 10, 2024 · 0 comments · Fixed by #54556
Closed

br: ebs backup progress uses # of stores, not # of volumes, to track progress #54555

michaelmdeng opened this issue Jul 10, 2024 · 0 comments · Fixed by #54556
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@michaelmdeng
Copy link
Contributor

michaelmdeng commented Jul 10, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Conduct EBS snapshot backup using tikv store w/ multiple volumes. View backup logs, which show progress based on # of tikvs, not # of volumes.

For large backups w/ many tikvs/volumes, progress quickly gets to 100% because volume progress is multiples of the tikv progress, but this is not an accurate representation of the actual progress of the backup/snapshots.

2. What did you expect to see? (Required)

Progress based on # of volumes.

3. What did you see instead (Required)

Progress based on # of tikvs, ex. logs from backup w/ single tikv, but 3 volumes

I0710 14:37:26.544144       9 backup.go:302] [2024/07/10 14:37:26.544 +00:00] [INFO] [progress.go:160] [progress] [step=backup] [progress=100.00%] [count="100 / 100"] [speed="? p/s"] [elapsed=1m38s] [remaining=1m38s]

4. What is your TiDB version? (Required)

tidb> select tidb_version();
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                                                            |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v6.5.4-v15.2-abnb
Edition: Community
Git Commit Hash: 26e36fba0c2e890e7a3d565113cb25091c890543
Git Branch: heads/v6.5.4-v15.2-abnb
UTC Build Time: 2024-05-08 21:58:30
GoVersion: go1.21.10
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: tikv |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.09 sec)
@michaelmdeng michaelmdeng added the type/bug The issue is confirmed as a bug. label Jul 10, 2024
@jebter jebter added severity/moderate component/br This issue is related to BR of TiDB. labels Jul 12, 2024
hawkingrei pushed a commit to hawkingrei/tidb that referenced this issue Jul 16, 2024
@BornChanger BornChanger added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants