Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package

[stefanb]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Try building with Go 1.23 rc1, eg in while testing Go 1.23 rc1 in homebrew:

• go 1.23, [email protected] 1.22.6 (new formula) Homebrew/homebrew-core#175310

2. What did you expect to see? (Required)

Succesfull build

3. What did you see instead (Required)

Build error:

  # github.com/pingcap/tidb/dumpling/cmd/dumpling
  link: github.com/pingcap/tidb/pkg/util/printer: invalid reference to runtime.buildVersion

4. What is your TiDB version? (Required)

---

Note, that Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

• https://tip.golang.org/doc/go1.23#linker
• cmd/link: lock down future uses of linkname golang/go#67401

It is used several times in tidb:
https://github.com/search?q=repo%3Apingcap%2Ftidb%20linkname&type=code

[hawkingrei]

Great, Thank for your report. We will start to support the go1.23. TiDB 8.5 will use go 1.23.

[rsc]

Note that you can use runtime/debug.ReadBuildInfo and then use info.GoVersion instead of runtime.buildVersion.

[hawkingrei]

It has been fixed by #53619.

I have success to build tidb with go1.23rc1.

[lance6716]

It has been fixed by #53619.

I have success to build tidb with go1.23rc1.

the original post is about dumpling not tidb. Can you check make build for dumpling?

[stefanb]

Please don't forget to tag a release sometime before Go 1.23 is released in August.