We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr.buildCopTasks
Introduced in #40825, the tracing logic for these two parts is apparently wrong.
The StartRegion() is called after the part that needs tracing finished.
StartRegion()
This will make the recorded time less than expected and can't cover what we want to trace.
tidb/pkg/store/copr/coprocessor.go
Lines 454 to 469 in b1b0995
The text was updated successfully, but these errors were encountered:
store/copr: fix tracing for copr.buildCopTasks (#53086)
9c5981c
close #53085
store/copr: fix tracing for copr.buildCopTasks (pingcap#53086)
9bf6532
close pingcap#53085
41f4964
Successfully merging a pull request may close this issue.
Bug Report
Introduced in #40825, the tracing logic for these two parts is apparently wrong.
The
StartRegion()
is called after the part that needs tracing finished.This will make the recorded time less than expected and can't cover what we want to trace.
tidb/pkg/store/copr/coprocessor.go
Lines 454 to 469 in b1b0995
The text was updated successfully, but these errors were encountered: