Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor refactor of writePhysicalTableRecord #52868

Closed
lance6716 opened this issue Apr 24, 2024 · 0 comments · Fixed by #52851
Closed

minor refactor of writePhysicalTableRecord #52868

lance6716 opened this issue Apr 24, 2024 · 0 comments · Fixed by #52851
Labels
component/ddl This issue is related to DDL of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@lance6716
Copy link
Contributor

lance6716 commented Apr 24, 2024 •
edited
Loading

Enhancement

That code is very old. It does not follow the context and errgroup pattern
@lance6716 lance6716 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 24, 2024
@lance6716 lance6716 mentioned this issue Apr 24, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 25, 2024
@lance6716
ddl: refactor the goroutines of writePhysicalTableRecord (#52851)
b0d756d 
close #52868
@tangenta tangenta added the component/ddl This issue is related to DDL of TiDB. label Jun 13, 2024
tangenta pushed a commit to ti-chi-bot/tidb that referenced this issue Dec 6, 2024
@lance6716 @tangenta
ddl: refactor the goroutines of writePhysicalTableRecord (pingcap#52851)
94eb874 
close pingcap#52868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ddl This issue is related to DDL of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: refactor the goroutines of writePhysicalTableRecord lance6716/tidb
2 participants
@lance6716 @tangenta