Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some sst might be skipped ingest when inner loop exhausted retry count #50198

Closed
D3Hunter opened this issue Jan 8, 2024 · 2 comments
Closed
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jan 8, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

when multiIngest = false, some sst might be skipped ingest when

  • there're at least 2 batches
  • on the first batch, inner loop exhausted retry count, as the err is not handled after this loop, it continue, so this batch is skipped
  • continue with second batch, success

for errCnt < maxRetryTimes {

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

6.5/6.1

@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. severity/major affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-7.1 may-affects-7.5 labels Jan 8, 2024
@D3Hunter D3Hunter removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-7.1 may-affects-7.5 labels Jan 8, 2024
@mittalrishabh
Copy link
Contributor

Good catch. As a fix, you are planning to handle error outside the inner loop too. Is that right ?
Please include me in the reviewer.

@jebter jebter added the component/lightning This issue is related to Lightning of TiDB. label Jan 9, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 24, 2024
@D3Hunter D3Hunter closed this as completed Feb 1, 2024
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants