Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance regression cause by add metrics in client-go #48107

Closed
crazycs520 opened this issue Oct 30, 2023 · 2 comments · Fixed by #48109
Closed

performance regression cause by add metrics in client-go #48107

crazycs520 opened this issue Oct 30, 2023 · 2 comments · Fixed by #48109
Assignees
@crazycs520
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement. type/performance

Comments

@crazycs520
Copy link
Contributor

Enhancement

Since tikv/client-go#996 brings some performance regression

TiDB workload: select_random_points

before:

image

after:

image
@crazycs520 crazycs520 added the type/enhancement The issue or PR belongs to an enhancement. label Oct 30, 2023
@crazycs520 crazycs520 self-assigned this Oct 30, 2023
@crazycs520 crazycs520 mentioned this issue Oct 30, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2023
@crazycs520
*: update tikv/client-go to fix performance regression (#48109)
1dfcd12 
close #48107
@crazycs520 crazycs520 mentioned this issue Oct 31, 2023
Merged
13 tasks
@Yui-Song
Copy link
Contributor

/label affects-7.5

@ti-chi-bot ti-chi-bot bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Oct 31, 2023
@Yui-Song
Copy link
Contributor

/type performance

ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2023
@crazycs520
*: update tikv/client-go to fix performance regression (#48109) (#48139)
93996da 
ref #47691, close #48107
@jebter jebter added the sig/transaction SIG:Transaction label Nov 23, 2023
@ti-chi-bot ti-chi-bot mentioned this issue Feb 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazycs520 crazycs520

Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement. type/performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update tikv/client-go to fix performance regression crazycs520/tidb
3 participants
@jebter @crazycs520 @Yui-Song