Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the error should be checked when failed to initialize the dml iterator in pitr #45853

Closed
Leavrth opened this issue Aug 7, 2023 · 0 comments
Closed
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Aug 7, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. restore

2. What did you expect to see? (Required)

success

3. What did you see instead (Required)

panic because the error is not checked and the iterator is nil.

tidb/br/pkg/task/stream.go

Lines 1269 to 1272 in 71e6696

updateRewriteRules(rewriteRules, schemasReplace)
logFilesIter, err := client.LoadDMLFiles(ctx)
pd := g.StartProgress(ctx, "Restore KV Files", int64(dataFileCount), !cfg.LogProgress)

4. What is your TiDB version? (Required)

v6.5.3

@Leavrth Leavrth added type/bug The issue is confirmed as a bug. severity/major component/br This issue is related to BR of TiDB. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Aug 7, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 labels Aug 7, 2023
@Leavrth Leavrth removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 labels Aug 7, 2023
@Leavrth Leavrth closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant