Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keepOrder for memIndexMerge #45387

Closed
Defined2014 opened this issue Jul 17, 2023 · 1 comment · Fixed by #43881
Closed

Support keepOrder for memIndexMerge #45387

Defined2014 opened this issue Jul 17, 2023 · 1 comment · Fixed by #43881
Assignees
@Defined2014
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Defined2014
Copy link
Contributor

Defined2014 commented Jul 17, 2023 •
edited
Loading

Enhancement

Now, we supported keepOrder for memIndexReader, memTableReader and memIndexLookUp, we can also support the keepOrder for memIndexMerge.
MemIndexMerge gets handles from different indexes, it couldn't keepOrder in scan phase. We could sorted it before return , like in L915 with sort.

tidb/executor/mem_reader.go

Lines 915 to 916 in 5027679

return memTblReader.getMemRows(ctx)

@Defined2014 Defined2014 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 17, 2023
@Defined2014 Defined2014 self-assigned this Jul 17, 2023
@Defined2014
Copy link
Contributor Author

Defined2014 commented Jul 17, 2023 •
edited
Loading

A ref link #43881 (review) for why we need this enhancement.

@winoros winoros mentioned this issue Jul 19, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 1, 2023
@winoros
planner, executor: support index merge's order prop push down at the …
0e068ed 
…normal way (#43881)

ref #41028, close #43577, close #45387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Defined2014 Defined2014

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner, executor: support index merge's order prop push down at the normal way winoros/tidb
1 participant
@Defined2014