Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTE may stuck in register OOM action when got killed by global memory limit #43749

Closed
guo-shaoge opened this issue May 12, 2023 · 1 comment · Fixed by #43758
Closed

CTE may stuck in register OOM action when got killed by global memory limit #43749

guo-shaoge opened this issue May 12, 2023 · 1 comment · Fixed by #43758
Assignees
@guo-shaoge
Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented May 12, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

If we got panic(e.g. oom cancel) in computeSeedPart, e.resTbl will fail to set err info, which makes other CTEExec that share the same CTEExec.resTbl register same memTracker again, which make dead loop of memTracker action rearrangement

Reproduce steps(We use failpoint to reproduce because it's hard to reproduce using SQL):

  1. Apply this diff: cd tidb && patch -p 1 < stuck_diff.txt
  2. cd tidb && make failpoint_enable
  3. cd tidb/execute && go test . --tags=intest -v -run TestCTESeedPanic

2. What did you expect to see? (Required)

sql runs with error

3. What did you see instead (Required)

sql stuck

4. What is your TiDB version? (Required)

master(79729c3)
@guo-shaoge guo-shaoge added the type/bug The issue is confirmed as a bug. label May 12, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels May 12, 2023
@guo-shaoge guo-shaoge mentioned this issue May 12, 2023
Merged
12 tasks
@guo-shaoge guo-shaoge added affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 and removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels May 12, 2023
@guo-shaoge guo-shaoge added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label May 12, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 12, 2023
@guo-shaoge
executor: fix cte may hang because register OOMAction repeatedly (#43758
cd334c4 
)

close #36896, close #43749
This was referenced May 12, 2023
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 18, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
cb98f2c 
) (#43774)

close #36896, close #43749
@VelocityLight VelocityLight added the affects-5.0 This bug affects 5.0.x versions. label May 18, 2023
@guo-shaoge
Copy link
Collaborator Author

v5.0 no cte feature.

@guo-shaoge guo-shaoge removed the affects-5.0 This bug affects 5.0.x versions. label May 19, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
3110690 
) (#43771)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this issue May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
507a4ca 
) (#43773)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this issue May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
833ba03 
) (#43772)

close #36896, close #43749
ti-chi-bot bot pushed a commit that referenced this issue May 23, 2023
@ti-chi-bot
executor: fix cte may hang because register OOMAction repeatedly (#43758
fe24d1f 
) (#43770)

close #36896, close #43749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guo-shaoge guo-shaoge

Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: fix cte may hang because register OOMAction repeatedly guo-shaoge/tidb
3 participants
@jebter @guo-shaoge @VelocityLight