Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable stale read when retry leader with keyIsLocked error #43659

Closed
you06 opened this issue May 9, 2023 · 0 comments · Fixed by #44240
Closed

Disable stale read when retry leader with keyIsLocked error #43659

you06 opened this issue May 9, 2023 · 0 comments · Fixed by #44240
Assignees
@you06
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@you06
Copy link
Contributor

you06 commented May 9, 2023

Enhancement

We have an optimization that when stale read meet dataIsNotReady, fallback to leader, and it may suffer keyIsLocked error from leader, after resolving lock, we need to retry directly with leader, unless there may be an useless dataIsNotReady.

Now:

follower(dataIsNotReady) -> leader(keyIsLocked) -> lock resolve -> follower(dataIsNotReady) -> leader(success)

Change to:

follower(dataIsNotReady) -> leader(keyIsLocked) -> lock resolve -> -> leader(success)
@you06 you06 added the type/enhancement The issue or PR belongs to an enhancement. label May 9, 2023
@you06 you06 mentioned this issue May 9, 2023
Merged
@cfzjywxk cfzjywxk mentioned this issue May 22, 2023
Closed
@you06 you06 mentioned this issue May 29, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 29, 2023
@you06
store/copr: disable stale read when meeting lock for cop (#44240)
10e6e42 
close #43659
This was referenced May 29, 2023
Merged
Merged
@VelocityLight VelocityLight added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels May 29, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 29, 2023
@ti-chi-bot
store/copr: disable stale read when meeting lock for cop (#44240) (#4…
97ef067 
…4251)

close #43659
@cfzjywxk cfzjywxk mentioned this issue Jun 21, 2023
Merged
16 tasks
@jebter jebter added the sig/transaction SIG:Transaction label Jul 3, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2023
@ti-chi-bot
store/copr: disable stale read when meeting lock for cop (#44240) (#4…
12c1cf2 
…4253)

close #43659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@you06 you06

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store/copr: disable stale read when meeting lock for cop you06/tidb
3 participants
@jebter @VelocityLight @you06