Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize multi-schema change for add indexes #41602

Closed
Tracked by #14766
Defined2014 opened this issue Feb 20, 2023 · 1 comment · Fixed by #47135
Closed
Tracked by #14766

Optimize multi-schema change for add indexes #41602

Defined2014 opened this issue Feb 20, 2023 · 1 comment · Fixed by #47135
Assignees
@Defined2014 @tangenta
Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.

Comments

@Defined2014
Copy link
Contributor

Enhancement

We can combine multiple "add index" operations in a multi-schema change, which will reduce table data scans and accelerate adding indexes speed.
@Defined2014 Defined2014 added type/enhancement The issue or PR belongs to an enhancement. sig/sql-infra SIG: SQL Infra labels Feb 20, 2023
@Defined2014 Defined2014 self-assigned this Feb 20, 2023
@Defined2014 Defined2014 mentioned this issue Feb 20, 2023
Closed
39 tasks
@Defined2014
Copy link
Contributor Author

Use #41718 to test it, I found the PR will decrease the performance in lightning mode. The bottleneck is lightning's write performance. So close this issue firstly.

@tangenta tangenta reopened this Sep 21, 2023
@tangenta tangenta mentioned this issue Sep 21, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 25, 2023
@tangenta
ddl: optimize adding multiple indexes (#47135)
29ba912 
close #41602
@tangenta tangenta mentioned this issue Sep 26, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 9, 2023
@tangenta
ddl: add more tests for multi-schema change (#47293)
fc4f8a1 
ref #41602
@tangenta tangenta mentioned this issue Oct 9, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 9, 2023
@tangenta
ddl: preserve index order for multi-schema change (#47483)
1f5179a 
ref #41602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Defined2014 Defined2014

@tangenta tangenta

Labels
sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: optimize adding multiple indexes tangenta/tidb
2 participants
@Defined2014 @tangenta