Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy logging for "set resource control" #40854

Closed
dveeden opened this issue Jan 30, 2023 · 5 comments · Fixed by #40739
Closed

Noisy logging for "set resource control" #40854

dveeden opened this issue Jan 30, 2023 · 5 comments · Fixed by #40739
Assignees
Labels
feature/developing the related feature is in development severity/minor type/bug The issue is confirmed as a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Jan 30, 2023

https://github.com/pingcap/tidb/blame/4ed456214d985b6b8b9ed9c49078fea4524927bc/domain/domain_sysvars.go#L79

[2023/01/30 08:14:00.733 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:14:30.738 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:15:00.743 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:15:30.748 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:16:00.754 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:16:30.757 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:17:00.761 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:17:30.766 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:18:00.772 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
$ ./bin/tidb-server -V
Release Version: v6.6.0-alpha-306-g28d0325ae
Edition: Community
Git Commit Hash: 28d0325ae12f080b978a147bba9f8467557019cd
Git Branch: master
UTC Build Time: 2023-01-30 06:26:21
GoVersion: go1.19.5
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore

This is with running TiDB with unistore like ./bin/tidb-server.

Seems to be related to #40732

Maybe change the level to debug and/or only log this when the value of enable changes?

cc @nolouch

@dveeden dveeden added the type/bug The issue is confirmed as a bug. label Jan 30, 2023
@ChenPeng2013 ChenPeng2013 added severity/minor feature/developing the related feature is in development labels Jan 31, 2023
@BornChanger
Copy link
Contributor

/assign @BornChanger

@BornChanger
Copy link
Contributor

Only logging when switch changed.

BornChanger added a commit to BornChanger/tidb that referenced this issue Feb 2, 2023
Signed-off-by: BornChanger <[email protected]>
@BornChanger
Copy link
Contributor

@dveeden please close this bug.

@jebter
Copy link

jebter commented Jul 27, 2023

/close

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

@jebter: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/developing the related feature is in development severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants