Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some internal transactions cost too much time in transaction retry #38136

Closed
jackysp opened this issue Sep 23, 2022 · 0 comments · Fixed by #38130
Closed

Some internal transactions cost too much time in transaction retry #38136

jackysp opened this issue Sep 23, 2022 · 0 comments · Fixed by #38130
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@jackysp
Copy link
Member

jackysp commented Sep 23, 2022

Enhancement

There will be many slow commit statements if there are many tidb-servers and the cluster is set to 'optimistic' transaction mode, because each tidb-server will update stats_meta in every 3 mins by default, and it will also affect the analyze statements.

image

This is due to the optimistic transaction will retry at most 10 times when write conflict occurs.

And there may other internal transactions meet this situation.

In #18952, we turn the auto commit transaction to pessimistic mode when retrying, I think it is better to turn all optimistic transaction to pessimistic when retrying.
@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Sep 23, 2022
@jackysp jackysp mentioned this issue Sep 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 30, 2022
@jackysp
session: turn the transaction to pessimistic mode when retrying (#38130)
d4f4c81 
close #38136
@cfzjywxk cfzjywxk mentioned this issue Nov 8, 2022
Merged
14 tasks
@ti-chi-bot ti-chi-bot mentioned this issue May 29, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 29, 2023
@ti-chi-bot
session: turn the transaction to pessimistic mode when retrying (#38130…
8c1282e 
…) (#44239)

close #38136
@VelocityLight VelocityLight added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label May 30, 2023
winoros pushed a commit to winoros/tidb that referenced this issue Jul 3, 2023
@jackysp @winoros
session: turn the transaction to pessimistic mode when retrying (ping…
0b6571a 
…cap#38130)

close pingcap#38136
@winoros winoros mentioned this issue Jul 3, 2023
Merged
12 tasks
@Ivy-YinSu Ivy-YinSu added the sig/transaction SIG:Transaction label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session: turn the transaction to pessimistic mode when retrying jackysp/tidb
3 participants
@jackysp @VelocityLight @Ivy-YinSu