Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To provide better compatibility, "not implemented" features can be suppress by other syntax #37984

Open
lance6716 opened this issue Sep 20, 2022 · 1 comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@lance6716
Copy link
Contributor

lance6716 commented Sep 20, 2022

Feature Request

Is your feature request related to a problem? Please describe:

TiDB supports less charset and collation than MySQL, take utf8mb3 as example.

If user want to migrate utf8mb3 schema to TiDB, the user will see

MySQL [(none)]> create database if not exists test character set utf8mb3;
ERROR 1115 (42000): Unknown character set: 'utf8mb3'

As a walkaround, user expects that after manually creating the schema with utf8mb4, the migrating progress should continue by IF NOT EXISTS. But the same error is still here because "Unknown character set" has a higher priority.

Describe the feature you'd like:

For the charset and collation that TiDB has not implemented, they should not cause "Unknown character set" error but "Unimplemented character set" error. And "Unimplemented character set" error have lower priority so that IF NOT EXISTS can suppress them. In this way migrating progress can continute by manually creating the schema in advance.

Describe alternatives you've considered:

migrating tools skip whole schema restoring phase

Teachability, Documentation, Adoption, Migration Strategy:

@lance6716 lance6716 added the type/feature-request Categorizes issue or PR as related to a new feature. label Sep 20, 2022
@lance6716 lance6716 changed the title To provide better compatibility, TiDB should treat "not implemented" features as not critical fail To provide better compatibility, "not implemented" features can be suppress by other syntax Sep 20, 2022
@lance6716
Copy link
Contributor Author

/cc @bb7133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant