Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling integration test always fail #37628

Closed
lance6716 opened this issue Sep 5, 2022 · 1 comment · Fixed by #37578 or #37622
Closed

dumpling integration test always fail #37628

lance6716 opened this issue Sep 5, 2022 · 1 comment · Fixed by #37578 or #37622
Labels
component/test severity/minor

Comments

@lance6716
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

server version returns 5.7.25-TiDB-5584f12 and lightning will panic because failed to parse this verison

2. What did you expect to see? (Required)

no error

3. What did you see instead (Required)

https://github.com/pingcap/tidb/runs/8187302242?check_suite_focus=true

4. What is your TiDB version? (Required)
@lance6716 lance6716 added the type/bug The issue is confirmed as a bug. label Sep 5, 2022
@lance6716
Copy link
Contributor Author

introduced by #37227

@lance6716 lance6716 mentioned this issue Sep 5, 2022
Merged
4 tasks
@lance6716 lance6716 mentioned this issue Sep 5, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 5, 2022
@YangKeao
types: merge json and types pkg (#37578)
170dafc 
close #37577, close #37628
ti-chi-bot pushed a commit that referenced this issue Sep 5, 2022
@lance6716
test: fix parsing ill-formed TiDB version will panic (#37622)
04dac01 
close #37628
@lichunzhu lichunzhu added component/test and removed type/bug The issue is confirmed as a bug. labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/minor
Projects
None yet
Milestone
No milestone
2 participants
@lance6716 @lichunzhu