Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: better error message for ADMIN CHECK/RECOVER/CLEANUP INDEX #37323

Closed
bb7133 opened this issue Aug 24, 2022 · 4 comments · Fixed by #38298
Closed

*: better error message for ADMIN CHECK/RECOVER/CLEANUP INDEX #37323

bb7133 opened this issue Aug 24, 2022 · 4 comments · Fixed by #38298
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@bb7133
Copy link
Member

bb7133 commented Aug 24, 2022

Enhancement

When a table is defined with clustered index, the 'primary key' does not exist actually(primary key = record), so for syntax like ADMIN CHECK INDEX xxx primary``, a better error message would be better:

Current:

tidb> create table t(a int key clustered);
tidb> admin recover index t `primary`;
ERROR 1105 (HY000): index `primary` is not found in table `t`

Not every user knows the definition of "clustered index", we could report another message like:

ERROR 1105 (HY000): index `primary` is not defined in table `t` when the clustered index is defined.
@bb7133 bb7133 added the type/enhancement The issue or PR belongs to an enhancement. label Aug 24, 2022
@bb7133 bb7133 assigned YangKeao and unassigned YangKeao Aug 24, 2022
@bb7133 bb7133 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 24, 2022
@azhsmesos
Copy link

please assigned it to me, i want to try it

@CbcWestwolf
Copy link
Member

/assign azhsmesos

@75asu
Copy link

75asu commented Sep 29, 2022

hi @bb7133 , as there is no response from @azhsmesos , I would like to take this one
could you please assign me this one and help me with the file where this change needs to be done, I checked a lot but found so many results, need some help here

@azhsmesos
Copy link

sorry,please assigned to @measutosh ,I've been really busy these days and I'm sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants