Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple domains may appear for one store under extreme cases #36791

Closed
xhebox opened this issue Aug 2, 2022 · 0 comments · Fixed by #36792
Closed

Multiple domains may appear for one store under extreme cases #36791

xhebox opened this issue Aug 2, 2022 · 0 comments · Fixed by #36792
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 severity/minor type/bug The issue is confirmed as a bug.

Comments

@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2022

Bug Report

#33737 introduced rwmutex for domap. But wlock part did not check the condition again. Thus multiple domains of one store may appear under heavy concurrent invokes of domap.

Minor issue since it is almost unreproduceable for users. Reported by @wjhuang2016 .

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@xhebox xhebox added type/bug The issue is confirmed as a bug. severity/minor affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 labels Aug 2, 2022
@xhebox xhebox mentioned this issue Aug 2, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 2, 2022
@xhebox
session: fix multiple domain creation racing in domap (#36792)
b1edc33 
close #36791
This was referenced Aug 2, 2022
Merged
Closed
ti-chi-bot pushed a commit that referenced this issue Aug 4, 2022
@ti-srebot
session: fix multiple domain creation racing in domap (#36792) (#36810)
a9e2b76 
close #36791
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session: fix multiple domain creation racing in domap xhebox/tidb
1 participant
@xhebox