Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumpling may get blocked when taskChan is full and cause connection timeout #36549

Closed
lance6716 opened this issue Jul 26, 2022 · 3 comments · Fixed by #38540
Closed

Dumpling may get blocked when taskChan is full and cause connection timeout #36549

lance6716 opened this issue Jul 26, 2022 · 3 comments · Fixed by #38540
Assignees
Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 component/dumpling This is related to Dumpling of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

dump a lot of tables

2. What did you expect to see? (Required)

no error

3. What did you see instead (Required)

[2022/07/25 14:29:11.058 +08:00] [INFO] [dump.go:103] ["begin to run Dump"]
...
[2022/07/25 14:43:22.932 +08:00] [INFO] [conn.go:70] ["cannot execute query"] [task=some_task] [unit=dump] [retryTime=1] [sql="SHOW COLUMNS FROM `some_db`.`some_tables`"] [args=null] [error="invalid connection"]

4. What is your TiDB version? (Required)

root cause

case taskChan <- task:

When taskChan is full dumpling will be blocked at sendTaskToChan. And metaConn has a 15-minute read timeout, it will be closed.

@lance6716 lance6716 added type/bug The issue is confirmed as a bug. severity/moderate component/dumpling This is related to Dumpling of TiDB. labels Jul 26, 2022
@lance6716
Copy link
Contributor Author

should be closed by #30673

@lance6716 lance6716 reopened this Oct 18, 2022
@lance6716
Copy link
Contributor Author

retry does not take effects https://asktug.com/t/topic/993973/9?u=lance6716

/cc @lichunzhu

@lance6716
Copy link
Contributor Author

When dumping from MySQL, the default configuration will not retry

baseConn := newBaseConn(metaConn, canRebuildConn(conf.Consistency, conf.TransactionalConsistency), rebuildConn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 component/dumpling This is related to Dumpling of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant