Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize error message when table pattern is wrong in table-filter to make it more clearly #36163

Closed
niubell opened this issue Jul 13, 2022 · 3 comments · Fixed by #36160
Closed

optimize error message when table pattern is wrong in table-filter to make it more clearly #36163

niubell opened this issue Jul 13, 2022 · 3 comments · Fixed by #36160
Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@niubell
Copy link
Contributor

niubell commented Jul 13, 2022

Enhancement

optimize error message when table pattern is wrong in table-filter to make it more clear and fix unit tests.
@niubell niubell added the type/enhancement The issue or PR belongs to an enhancement. label Jul 13, 2022
@niubell
Copy link
Contributor Author

niubell commented Jul 13, 2022

/label component/lightning

@ti-chi-bot
Copy link
Member

@niubell: The label(s) component/lightning cannot be applied. These labels are supported: challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, needs-cherry-pick-5.3, needs-cherry-pick-5.4, needs-cherry-pick-6.0, needs-cherry-pick-6.1, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1.

In response to this:

/label component/lightning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@niubell
Copy link
Contributor Author

niubell commented Jul 13, 2022

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Jul 13, 2022
@niubell niubell mentioned this issue Jul 13, 2022
Merged
1 task
ti-chi-bot pushed a commit that referenced this issue Jul 13, 2022
@niubell
table-filter: optimize table pattern message and unit tests (#36160)
d93bc7a 
close #36163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

table-filter: optimize table pattern message and unit tests niubell/tidb
2 participants
@niubell @ti-chi-bot