Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test case 'executor TestIndexMergeRuntimeStats' fail on real TiKV #35829

Closed
Tracked by #35633
tiancaiamao opened this issue Jun 30, 2022 · 0 comments · Fixed by #35839
Closed
Tracked by #35633

Unit test case 'executor TestIndexMergeRuntimeStats' fail on real TiKV #35829

tiancaiamao opened this issue Jun 30, 2022 · 0 comments · Fixed by #35839
Assignees
Labels
severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

I'm testing paging protocol by running tidb UT with a real TiKV using this branch #35647

tiup playground nightly --mode tikv-slim
cd executor
go test -run TestIndexMergeRuntimeStats -with-tikv 127.0.0.1:2379

2. What did you expect to see? (Required)

No error

3. What did you see instead (Required)

--- FAIL: TestIndexMergeRuntimeStats (3.79s)
    testkit.go:174: 
        	Error Trace:	testkit.go:174
        	            				testkit.go:168
        	            				testkit.go:108
        	            				executor_test.go:3070
        	Error:      	Received unexpected error:
        	            	runtime error: invalid memory address or nil pointer dereference
        	            	github.com/pingcap/tidb/store/copr.(*copIteratorWorker).handleTask.func1
        	            		/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:664
        	            	runtime.gopanic
        	            		/home/genius/project/go/src/runtime/panic.go:838
        	            	runtime.panicmem
        	            		/home/genius/project/go/src/runtime/panic.go:220
        	            	runtime.sigpanic
        	            		/home/genius/project/go/src/runtime/signal_unix.go:818
        	            	github.com/pingcap/tidb/store/copr.(*copIteratorWorker).handleCopResponse
        	            		/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:961
        	            	github.com/pingcap/tidb/store/copr.(*copIteratorWorker).handleTaskOnce
        	            		/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:786
        	            	github.com/pingcap/tidb/store/copr.(*copIteratorWorker).handleTask
        	            		/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:674
        	            	github.com/pingcap/tidb/store/copr.(*copIteratorWorker).run
        	            		/home/genius/project/src/github.com/pingcap/tidb/store/copr/coprocessor.go:416
        	            	runtime.goexit
        	            		/home/genius/project/go/src/runtime/asm_amd64.s:1571
        	Test:       	TestIndexMergeRuntimeStats
        	Messages:   	sql:select /*+ use_index_merge(t1, primary, t1a) */ * from t1 where id < 2 or a > 4 order by a, args:[]
FAIL

I've verified it's not caused by the changes from paging... instead, it's a bug on execution_info with cop cache.

4. What is your TiDB version? (Required)

master

commit 47a4f3a017768dda0b9a826451486c5539bc8427 (HEAD -> master, origin/master, origin/HEAD)
Author: Weizhen Wang <[email protected]>
Date:   Wed Jun 29 20:16:40 2022 +0800

    *: enable unconvert (#35821)
    
    ref pingcap/tidb#35345
@tiancaiamao tiancaiamao added type/bug The issue is confirmed as a bug. severity/minor labels Jun 30, 2022
@tiancaiamao tiancaiamao self-assigned this Jun 30, 2022
@ChenPeng2013 ChenPeng2013 added the sig/execution SIG execution label Jun 30, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 30, 2022
you06 added a commit to you06/tidb that referenced this issue Jul 1, 2022
Signed-off-by: you06 <[email protected]>

fix tests

Signed-off-by: you06 <[email protected]>

fix test

Signed-off-by: you06 <[email protected]>

update

Signed-off-by: you06 <[email protected]>

update bazel

Signed-off-by: you06 <[email protected]>

fix test

Signed-off-by: you06 <[email protected]>

fix test

Signed-off-by: you06 <[email protected]>

update

Signed-off-by: you06 <[email protected]>

update client-go

Signed-off-by: you06 <[email protected]>

update client-go

Signed-off-by: you06 <[email protected]>

update grafana

Signed-off-by: you06 <[email protected]>

update bazel

Signed-off-by: you06 <[email protected]>

display by stack

Signed-off-by: you06 <[email protected]>

set request source for ctx of

Signed-off-by: you06 <[email protected]>

address comment

Signed-off-by: you06 <[email protected]>

address comment

Signed-off-by: you06 <[email protected]>

parser, ddl: support decoding binary literal in set/enum (pingcap#35822)

close pingcap#31338

executor: fix a nil point when @@tidb_enable_collect_execution_info is off and cop cache is on (pingcap#35839)

close pingcap#35829

ddl: support drop columns for multi-schema change (pingcap#35737)

ref pingcap#14766

planner: don't push down predicates over table dual (pingcap#35669)

close pingcap#35527

*: Remove some useless staleness code (pingcap#35849)

close pingcap#35848

ddl: fix potential wrong column definition when setting default value (pingcap#35845)

close pingcap#35846

*: add timeout for test cases (pingcap#35844)

ddl: remove `onDropColumns` and `onAddColumns` (pingcap#35862)

ref pingcap#14766

*: Fix Dockerfile (pingcap#35835)

close pingcap#35828

server: refactor TestConnExecutionTimeout (pingcap#35865)

close pingcap#35868

fix test

Signed-off-by: you06 <[email protected]>

fix lint

Signed-off-by: you06 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
2 participants