Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR: incorrect total summary time for backup ranges #35553

Closed
ixuh12 opened this issue Jun 21, 2022 · 2 comments · Fixed by #35552
Closed

BR: incorrect total summary time for backup ranges #35553

ixuh12 opened this issue Jun 21, 2022 · 2 comments · Fixed by #35552
Assignees
@ixuh12
Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/moderate type/enhancement The issue or PR belongs to an enhancement.

Comments

@ixuh12
Copy link
Contributor

ixuh12 commented Jun 21, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run BR, it shows the incorrect total time for backup ranges.

2. What did you expect to see? (Required)

Longer total summary time for backup ranges since the total summary time should at least include the backup range finished time.

3. What did you see instead (Required)

The total time for backup ranges is quicker than the time taken for finishing backup ranges.

[2022/06/16 00:03:22.387 -04:00] [INFO] [client.go:581] ["backup range finished"] [range
-sn=0] [take=682.314138ms]
[2022/06/16 00:03:22.387 -04:00] [INFO] [client.go:567] ["Backup Ranges"] [take=67ns]

4. What is your TiDB version? (Required)

Current master branch.
@ixuh12 ixuh12 added the type/bug The issue is confirmed as a bug. label Jun 21, 2022
@ixuh12 ixuh12 mentioned this issue Jun 21, 2022
Merged
12 tasks
@seiya-annie seiya-annie added the component/br This issue is related to BR of TiDB. label Jun 21, 2022
@joccau
Copy link
Member

joccau commented Jun 23, 2022

/label affects-6.1
/label affects-6.0

@ti-chi-bot ti-chi-bot added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.0 labels Jun 23, 2022
@joccau
Copy link
Member

joccau commented Jun 23, 2022

/assign @ixuh12

@joccau joccau added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Jun 23, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 23, 2022
@ixuh12
BR: fix backup ranges total time summary log (#35552)
3c83cd3 
close #35553
This was referenced Jun 23, 2022
Closed
Merged
This was referenced Aug 29, 2022
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 26, 2023
@ti-srebot
BR: fix backup ranges total time summary log (#35552) (#35702)
7e00dc2 
close #35553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixuh12 ixuh12

Labels
affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/moderate type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BR: fix backup ranges total time summary log ixuh12/tidb
5 participants
@fubinzh @seiya-annie @ixuh12 @joccau @ti-chi-bot