Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initStatsTopN4Chunk() doesn't sort TopN for statistics sometimes #34216

Closed
time-and-fate opened this issue Apr 25, 2022 · 0 comments · Fixed by #34234
Closed

initStatsTopN4Chunk() doesn't sort TopN for statistics sometimes #34216

time-and-fate opened this issue Apr 25, 2022 · 0 comments · Fixed by #34234
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/statistics severity/moderate sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@time-and-fate
Copy link
Member

Bug Report

As the title says, the logic of initStatsTopN4Chunk() is not correct. The stats for all tables are handled here, but it assumes it's handling stats on one table. The TopNs of different tables that have the same column ID are not guaranteed to be sorted.
@time-and-fate time-and-fate added type/bug The issue is confirmed as a bug. component/statistics sig/planner SIG: Planner labels Apr 25, 2022
@time-and-fate time-and-fate mentioned this issue Apr 26, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 26, 2022
@time-and-fate
statistics: fix init topn not sorted (#34234)
e158017 
ref #32758, close #34216
This was referenced Apr 28, 2022
Closed
Merged
@winoros winoros added affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 labels Apr 28, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 28, 2022
@ti-srebot
statistics: fix init topn not sorted (#34234) (#34317)
92be685 
ref #32758, close #34216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/statistics severity/moderate sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: fix init topn not sorted time-and-fate/tidb
2 participants
@winoros @time-and-fate