-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diagnose: try to differentiate between internal and external requests #33963
Comments
For the internal request tracking enhancement, I've created a tracking issue here. |
Thanks for the reminder. This issue is much more systematic work, trying to labeling all requests with their sources. Maybe we will reimplement #34861 with more unified mechanisms. |
#34861 pushed |
Enhancement
Currently the tidb-server could trigger several different types of internal requests, they could be triggered by some background tasks such as
auto analyze
,statistics feedback
,ddl backfill
,gc resolve lock
,gc unsafe destroy range
, etc. Also, the entries are different some of them may useExecRestrictedSQL
and some may use raw transaction interfaces. These requests would be turned into kv requests just like the user kv requests, but there's no way to differentiate them conveniently.As these internal requests could use resources and affect the performance when the resources are limited on the cloud, it's difficult to do the performance tuning if the current bottleneck is introduced by some ongoing background tasks. To make the performance diagnosis easier, we could add separate tags for these internal kv requests and try to display how many resources are used by them so that it could be much easier to tell if the internal tasks affect the cluster performance a lot.
The detailed work plan is:
Note this is just to enhance the path from tidb to tikv, there're still some background tasks like
peer move
,data compaction
in the tikv side, these internal tasks could be discussed in another document.The text was updated successfully, but these errors were encountered: