You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the two features, Stale Read and Local Txn were developed together, the former borrows many of the concepts from the latter. TxnScope should be a term referring to the Global/Local Transaction scopes specifically. However, in the code of Stale Read, TxnScope is also used widely to indicate the TiKV locality, which brings some confusion into the code readability.
panic("request builder get staleness option fail")
}
})
err:=builder.verifyTxnScope()
iferr!=nil {
builder.err=err
}
return&builder.Request, builder.err
}
We should decouple the TxnScope from the Stale Read code to make it more clear when we try to write some code that is related to the locality of the TiKV store.
The text was updated successfully, but these errors were encountered:
Enhancement
Since the two features, Stale Read and Local Txn were developed together, the former borrows many of the concepts from the latter.
TxnScope
should be a term referring to the Global/Local Transaction scopes specifically. However, in the code of Stale Read,TxnScope
is also used widely to indicate the TiKV locality, which brings some confusion into the code readability.tidb/distsql/request_builder.go
Lines 51 to 75 in ab30467
We should decouple the
TxnScope
from the Stale Read code to make it more clear when we try to write some code that is related to the locality of the TiKV store.The text was updated successfully, but these errors were encountered: