-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staticcheck report some errors #13456
Comments
@zhouqiang-cl maybe we can add this to CI later |
@siddontang yes. when this issue is fixed |
Can this be fixed in one pr or separately? |
@zz-jason PTAL |
Here is more static check error using latest version ([email protected])
|
https://github.com/pingcap/parser also need to do the |
@mahjonp PTAL. and add this to CI. I think it can work on CI now |
staticcheck on 0a0e388
|
@zz-jason PTAL |
we will add it in CI. But first this issue need to fix |
@zhouqiang-cl @zz-jason there are quite some static check rules, we'd better pick some of them running on CI jobs: https://staticcheck.io/docs/checks#checks |
@mahjonp I think we can |
Bug Report
Please answer these questions before submitting your issue. Thanks!
run
What did you expect to see?
No output
What did you see instead?
tidb-server -V
or runselect tidb_version();
on TiDB)?master
The text was updated successfully, but these errors were encountered: