address comment

Signed-off-by: AilinKid <[email protected]>
pingcap · Sep 19, 2023 · f9456a2 · f9456a2
1 parent c355d83
commit f9456a2
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/planner/core/rule_aggregation_push_down.go b/planner/core/rule_aggregation_push_down.go
@@ -574,6 +574,7 @@ func (a *aggregationPushDownSolver) aggPushDown(p LogicalPlan, opt *logicalOptim
 							break
 						}
 						newAggFuncsArgs = append(newAggFuncsArgs, newArgs)
+						// for ordeByItems, treat it like agg func's args, if it can be substituted by underlying projection's expression recording them temporarily.
 						if len(aggFunc.OrderByItems) != 0 {
 							oldAggOrderItems = append(oldAggOrderItems, aggFunc.OrderByItems)
 							newOrderByItems := make([]expression.Expression, 0, len(aggFunc.OrderByItems))