*: tiny update

pingcap · Sep 10, 2024 · ed0c7a9 · ed0c7a9
1 parent ca05911
commit ed0c7a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/ddl/ddl.go b/ddl/ddl.go
@@ -1248,8 +1248,10 @@ func (d *ddl) SwitchMDL(enable bool) error {
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
 	defer cancel()
 
+	logutil.BgLogger().Info(fmt.Sprintf("xxx---------------- 000 mdl:%v, concurrent:%v", enable, variable.DefTiDBEnableConcurrentDDL))
 	// Disable MDL for test.
 	if enable && !variable.DefTiDBEnableConcurrentDDL {
+		logutil.BgLogger().Info("xxx---------------- 111 mdl")
 		sql := fmt.Sprintf("UPDATE HIGH_PRIORITY %[1]s.%[2]s SET VARIABLE_VALUE = %[4]d WHERE VARIABLE_NAME = '%[3]s'",
 			mysql.SystemDB, mysql.GlobalVariablesTable, variable.TiDBEnableMDL, 0)
 		sess, err := d.sessPool.get()

diff --git a/server/tidb_test.go b/server/tidb_test.go
@@ -3325,6 +3325,9 @@ func TestAuthSocket(t *testing.T) {
 }
 
 func TestIssue53634(t *testing.T) {
+	if !variable.DefTiDBEnableConcurrentDDL {
+		t.Logf("mdl defConcurrent:%v", variable.DefTiDBEnableConcurrentDDL)
+	}
 	cfg := newTestConfig()
 	cfg.Lease = "20s"
 	cfg.Port = 4123

diff --git a/sessionctx/variable/sysvar.go b/sessionctx/variable/sysvar.go
@@ -1128,6 +1128,7 @@ var defaultSysVars = []*SysVar{
 		return BoolToOnOff(EnableConcurrentDDL.Load()), nil
 	}},
 	{Scope: ScopeGlobal, Name: TiDBEnableMDL, Value: BoolToOnOff(DefTiDBEnableMDL), Type: TypeBool, SetGlobal: func(_ context.Context, vars *SessionVars, val string) error {
+		logutil.BgLogger().Info(fmt.Sprintf("xxx---------------- mdl previous:%v, set:%v", EnableMDL.Load(), val))
 		if EnableMDL.Load() != TiDBOptOn(val) {
 			err := SwitchMDL(TiDBOptOn(val))
 			if err != nil {