privilege: Remove TestAbnormalMySQLTable (#54925)

close #54924
pingcap · Jul 26, 2024 · da7d83f · da7d83f
1 parent 0dff610
commit da7d83f
Showing 1 changed file with 0 additions and 77 deletions.
diff --git a/pkg/privilege/privileges/cache_test.go b/pkg/privilege/privileges/cache_test.go
@@ -366,83 +366,6 @@ func TestFindAllUserEffectiveRoles(t *testing.T) {
 	require.Equal(t, "r_3", ret[1].Username)
 }
 
-func TestAbnormalMySQLTable(t *testing.T) {
-	store := createStoreAndPrepareDB(t)
-
-	tk := testkit.NewTestKit(t, store)
-
-	// Simulate the case mysql.user is synchronized from MySQL.
-	tk.MustExec("DROP TABLE mysql.user;")
-	tk.MustExec("USE mysql;")
-	tk.MustExec(`CREATE TABLE user (
-  Host char(60) COLLATE utf8_bin NOT NULL DEFAULT '',
-  User char(16) COLLATE utf8_bin NOT NULL DEFAULT '',
-  Password char(41) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '',
-  Select_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Insert_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Update_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Delete_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Drop_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Reload_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Shutdown_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Process_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  File_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Config_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Grant_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  References_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Index_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Alter_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Show_db_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Super_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_tmp_table_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Lock_tables_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Execute_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Repl_slave_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Repl_client_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_view_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Show_view_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_routine_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Alter_routine_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_user_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Event_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Trigger_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_tablespace_priv enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  Create_role_priv ENUM('N','Y') NOT NULL DEFAULT 'N',
-  Drop_role_priv ENUM('N','Y') NOT NULL DEFAULT 'N',
-  Account_locked ENUM('N','Y') NOT NULL DEFAULT 'N',
-  ssl_type enum('','ANY','X509','SPECIFIED') CHARACTER SET utf8 NOT NULL DEFAULT '',
-  ssl_cipher blob NOT NULL,
-  x509_issuer blob NOT NULL,
-  x509_subject blob NOT NULL,
-  max_questions int(11) unsigned NOT NULL DEFAULT '0',
-  max_updates int(11) unsigned NOT NULL DEFAULT '0',
-  max_connections int(11) unsigned NOT NULL DEFAULT '0',
-  max_user_connections int(11) unsigned NOT NULL DEFAULT '0',
-  plugin char(64) COLLATE utf8_bin DEFAULT 'mysql_native_password',
-  authentication_string text COLLATE utf8_bin,
-  token_issuer varchar(255),
-  user_attributes json,
-  password_expired		ENUM('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N',
-  password_last_changed	TIMESTAMP DEFAULT CURRENT_TIMESTAMP(),
-  password_lifetime		SMALLINT UNSIGNED,
-  PRIMARY KEY (Host,User)
-) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_bin COMMENT='Users and global privileges';`)
-	tk.MustExec(`INSERT INTO user VALUES ('localhost','root','','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','','','','',0,0,0,0,'mysql_native_password','', '', 'null', 'N', current_timestamp(), null);
-`)
-	var p privileges.MySQLPrivilege
-	require.NoError(t, p.LoadUserTable(tk.Session()))
-	activeRoles := make([]*auth.RoleIdentity, 0)
-	// MySQL mysql.user table schema is not identical to TiDB, check it doesn't break privilege.
-	require.True(t, p.RequestVerification(activeRoles, "root", "localhost", "test", "", "", mysql.SelectPriv))
-
-	// Absent of those tables doesn't cause error.
-	tk.MustExec("DROP TABLE mysql.db;")
-	tk.MustExec("DROP TABLE mysql.tables_priv;")
-	tk.MustExec("DROP TABLE mysql.columns_priv;")
-	require.NoError(t, p.LoadAll(tk.Session()))
-}
-
 func TestSortUserTable(t *testing.T) {
 	var p privileges.MySQLPrivilege
 	p.User = []privileges.UserRecord{