Skip to content

Commit

Permalink
test: add a test case for cleanup predicate columns
Browse files Browse the repository at this point in the history
Signed-off-by: hi-rustin <[email protected]>
  • Loading branch information
Rustin170506 committed May 30, 2024
1 parent 04c66ee commit ce5d30e
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/statistics/handle/usage/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ go_test(
timeout = "short",
srcs = [
"index_usage_integration_test.go",
"predicate_column_test.go",
"session_stats_collect_test.go",
],
embed = [":usage"],
flaky = True,
shard_count = 3,
deps = [
"//pkg/infoschema",
"//pkg/parser/model",
Expand Down
57 changes: 57 additions & 0 deletions pkg/statistics/handle/usage/predicate_column_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
// Copyright 2024 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package usage_test

import (
"testing"

"github.com/pingcap/tidb/pkg/parser/model"
"github.com/pingcap/tidb/pkg/testkit"
"github.com/stretchr/testify/require"
)

func TestCleanupPredicateColumns(t *testing.T) {
store, dom := testkit.CreateMockStoreAndDomain(t)
tk := testkit.NewTestKit(t, store)

// Create table and select data with predicate.
tk.MustExec("use test")
tk.MustExec("create table t (a int, b int)")
tk.MustExec("insert into t values (1, 1), (2, 2), (3, 3)")
// Enable column tracking.
tk.MustExec("set global tidb_enable_column_tracking = 1")
tk.MustQuery("select * from t where a > 1").Check(testkit.Rows("2 2", "3 3"))
tk.MustQuery("select * from t where b > 1").Check(testkit.Rows("2 2", "3 3"))

// Dump the statistics usage.
h := dom.StatsHandle()
err := h.DumpColStatsUsageToKV()
require.NoError(t, err)

// Check the statistics usage.
rows := tk.MustQuery("select * from mysql.column_stats_usage").Rows()
require.Len(t, rows, 2)

// Drop column b.
tk.MustExec("alter table t drop column b")
// Get table ID.
is := dom.InfoSchema()
tbl, err := is.TableByName(model.NewCIStr("test"), model.NewCIStr("t"))
require.NoError(t, err)
columns, err := h.GetPredicateColumns(tbl.Meta().ID)
require.NoError(t, err)
// FIXME: cleanup predicate columns.
require.Len(t, columns, 2)
}

0 comments on commit ce5d30e

Please sign in to comment.