'LogBin' still keep an independent case

pingcap · Feb 19, 2019 · 82e7be3 · 82e7be3
1 parent f862b4c
commit 82e7be3
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/sessionctx/variable/varsutil.go b/sessionctx/variable/varsutil.go
@@ -340,6 +340,15 @@ func ValidateSetSystemVar(vars *SessionVars, name string, value string) (string,
 			return "0", nil
 		}
 		return value, ErrWrongValueForVar.GenWithStackByArgs(name, value)
+	case LogBin:
+		if strings.EqualFold(value, "ON") || value == "1" {
+			return "ON", nil
+		}
+		if strings.EqualFold(value, "OFF") || value == "0" {
+			return "OFF", nil
+		}
+		return value, ErrWrongValueForVar.GenWithStackByArgs(name, value)
+
 	case AutocommitVar, TiDBSkipUTF8Check, TiDBOptAggPushDown,
 		TiDBOptInSubqToJoinAndAgg,
 		TiDBBatchInsert, TiDBDisableTxnAutoRetry, TiDBEnableStreaming,
@@ -348,7 +357,7 @@ func ValidateSetSystemVar(vars *SessionVars, name string, value string) (string,
 			return value, nil
 		}
 		return value, ErrWrongValueForVar.GenWithStackByArgs(name, value)
-	case TiDBEnableTablePartition, LogBin:
+	case TiDBEnableTablePartition:
 		switch {
 		case strings.EqualFold(value, "ON") || value == "1":
 			return "on", nil