address comments

pingcap · May 18, 2023 · 826d92e · 826d92e
1 parent 408c42e
commit 826d92e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/planner/core/rule_aggregation_push_down.go b/planner/core/rule_aggregation_push_down.go
@@ -542,8 +542,12 @@ func (a *aggregationPushDownSolver) aggPushDown(p LogicalPlan, opt *logicalOptim
 					for j := range funcsArgs {
 						if oldAggFuncsArgs[i][j].GetType().EvalType() != newAggFuncsArgs[i][j].GetType().EvalType() {
 							noSideEffects = false
+							break
 						}
 					}
+					if !noSideEffects {
+						break
+					}
 				}
 				if noSideEffects {
 					agg.GroupByItems = newGbyItems