session: remove useless parser object in SessionHandle of bindinfo pa…

…ckage (#39439)
pingcap · Nov 29, 2022 · 5b16086 · 5b16086
1 parent f1215a5
commit 5b16086
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/bindinfo/session_handle.go b/bindinfo/session_handle.go
@@ -33,13 +33,12 @@ import (
 
 // SessionHandle is used to handle all session sql bind operations.
 type SessionHandle struct {
-	ch     *bindCache
-	parser *parser.Parser
+	ch *bindCache
 }
 
 // NewSessionBindHandle creates a new SessionBindHandle.
-func NewSessionBindHandle(parser *parser.Parser) *SessionHandle {
-	sessionHandle := &SessionHandle{parser: parser}
+func NewSessionBindHandle() *SessionHandle {
+	sessionHandle := &SessionHandle{}
 	sessionHandle.ch = newBindCache()
 	return sessionHandle
 }

diff --git a/session/session.go b/session/session.go
@@ -3135,7 +3135,7 @@ func createSessionWithOpt(store kv.Storage, opt *Opt) (*session, error) {
 	s.sessionVars.BinlogClient = binloginfo.GetPumpsClient()
 	s.txn.init()
 
-	sessionBindHandle := bindinfo.NewSessionBindHandle(parser.New())
+	sessionBindHandle := bindinfo.NewSessionBindHandle()
 	s.SetValue(bindinfo.SessionBindInfoKeyType, sessionBindHandle)
 	s.SetSessionStatesHandler(sessionstates.StateBinding, sessionBindHandle)
 	return s, nil