*: enable race for some part (#38288)

pingcap · Oct 8, 2022 · 4adfaf1 · 4adfaf1
1 parent fb4adc4
commit 4adfaf1
Show file tree

Hide file tree

Showing 14 changed files with 15 additions and 4 deletions.
diff --git a/DEPS.bzl b/DEPS.bzl
@@ -3422,8 +3422,8 @@ def go_deps():
         name = "com_github_tikv_client_go_v2",
         build_file_proto_mode = "disable_global",
         importpath = "github.com/tikv/client-go/v2",
-        sum = "h1:GJNu6XDT8W2Oahh+w/fhb37PNhFr4EZjdehIklZnhU4=",
-        version = "v2.0.1-0.20220921101651-ce9203ef66e9",
+        sum = "h1:TxDSQAmtGdE34BvOaYF35mRrAXePeZEq8quvuAwrKsI=",
+        version = "v2.0.1-0.20220923061703-33efe476e022",
     )
     go_repository(
         name = "com_github_tikv_pd_client",

diff --git a/br/pkg/lightning/backend/importer/BUILD.bazel b/br/pkg/lightning/backend/importer/BUILD.bazel
diff --git a/br/pkg/lightning/backend/kv/BUILD.bazel b/br/pkg/lightning/backend/kv/BUILD.bazel
@@ -50,6 +50,7 @@ go_test(
         "sql2kv_test.go",
     ],
     flaky = True,
+    race = "on",
     deps = [
         ":kv",
         "//br/pkg/lightning/common",

diff --git a/br/pkg/lightning/checkpoints/BUILD.bazel b/br/pkg/lightning/checkpoints/BUILD.bazel
@@ -42,6 +42,7 @@ go_test(
     ],
     embed = [":checkpoints"],
     flaky = True,
+    race = "on",
     deps = [
         "//br/pkg/lightning/checkpoints/checkpointspb",
         "//br/pkg/lightning/config",

diff --git a/br/pkg/rtree/BUILD.bazel b/br/pkg/rtree/BUILD.bazel
@@ -28,6 +28,7 @@ go_test(
         "rtree_test.go",
     ],
     flaky = True,
+    race = "on",
     deps = [
         ":rtree",
         "//testkit/testsetup",

diff --git a/planner/core/BUILD.bazel b/planner/core/BUILD.bazel
@@ -35,6 +35,7 @@ go_library(
         "plan_cacheable_checker.go",
         "plan_cost.go",
         "plan_cost_detail.go",
+        "plan_cost_ver2.go",
         "plan_stats.go",
         "plan_to_pb.go",
         "planbuilder.go",
@@ -186,6 +187,7 @@ go_test(
         "plan_cacheable_checker_test.go",
         "plan_cost_detail_test.go",
         "plan_cost_test.go",
+        "plan_cost_ver2_test.go",
         "plan_stats_test.go",
         "plan_test.go",
         "plan_to_pb_test.go",

diff --git a/server/BUILD.bazel b/server/BUILD.bazel
@@ -140,6 +140,7 @@ go_test(
     ],
     embed = [":server"],
     flaky = True,
+    race = "on",
     shard_count = 50,
     deps = [
         "//config",

diff --git a/sessionctx/variable/BUILD.bazel b/sessionctx/variable/BUILD.bazel
@@ -91,6 +91,7 @@ go_test(
         "//parser/terror",
         "//planner/core",
         "//sessionctx/stmtctx",
+        "//testkit",
         "//testkit/testsetup",
         "//types",
         "//util/execdetails",

diff --git a/sessiontxn/isolation/BUILD.bazel b/sessiontxn/isolation/BUILD.bazel
@@ -15,6 +15,7 @@ go_library(
         "//config",
         "//infoschema",
         "//kv",
+        "//metrics",
         "//parser/ast",
         "//parser/mysql",
         "//parser/terror",

diff --git a/store/copr/BUILD.bazel b/store/copr/BUILD.bazel
@@ -68,6 +68,7 @@ go_test(
     ],
     embed = [":copr"],
     flaky = True,
+    race = "on",
     deps = [
         "//kv",
         "//store/driver/backoff",

diff --git a/table/BUILD.bazel b/table/BUILD.bazel
@@ -44,6 +44,7 @@ go_test(
     ],
     embed = [":table"],
     flaky = True,
+    race = "on",
     shard_count = 50,
     deps = [
         "//errno",

diff --git a/telemetry/cte_test/BUILD.bazel b/telemetry/cte_test/BUILD.bazel
@@ -5,6 +5,7 @@ go_test(
     timeout = "short",
     srcs = ["cte_test.go"],
     flaky = True,
+    race = "on",
     deps = [
         "//config",
         "//domain",

diff --git a/telemetry/cte_test/cte_test.go b/telemetry/cte_test/cte_test.go
@@ -29,6 +29,7 @@ import (
 	"github.com/pingcap/tidb/testkit/testsetup"
 	"github.com/stretchr/testify/require"
 	"go.etcd.io/etcd/tests/v3/integration"
+	"go.opencensus.io/stats/view"
 	"go.uber.org/goleak"
 )
 
@@ -37,7 +38,6 @@ func TestMain(m *testing.M) {
 
 	opts := []goleak.Option{
 		goleak.IgnoreTopFunction("go.etcd.io/etcd/client/pkg/v3/logutil.(*MergeLogger).outputLoop"),
-		goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
 		goleak.IgnoreTopFunction("github.com/golang/glog.(*loggingT).flushDaemon"),
 	}
 
@@ -120,6 +120,7 @@ func newSuite(t *testing.T) *testSuite {
 		suite.dom.Close()
 		err = suite.store.Close()
 		require.NoError(t, err)
+		view.Stop()
 	}
 
 	return suite

diff --git a/telemetry/main_test.go b/telemetry/main_test.go
@@ -38,7 +38,6 @@ func TestMain(m *testing.M) {
 
 	opts := []goleak.Option{
 		goleak.IgnoreTopFunction("go.etcd.io/etcd/client/pkg/v3/logutil.(*MergeLogger).outputLoop"),
-		goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
 		goleak.IgnoreTopFunction("github.com/golang/glog.(*loggingT).flushDaemon"),
 	}