add test

Signed-off-by: yisaer <[email protected]>
pingcap · Nov 8, 2022 · 386f9ab · 386f9ab
1 parent 2a3c459
commit 386f9ab
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/domain/plan_replayer.go b/domain/plan_replayer.go
@@ -107,7 +107,7 @@ func (p *dumpFileGcChecker) gcDumpFilesByPath(path string, t time.Duration) {
 				continue
 			}
 			logutil.BgLogger().Info("dumpFileGcChecker successful", zap.String("filename", fileName))
-			if isPlanReplayer {
+			if isPlanReplayer && p.planReplayerHandle != nil {
 				p.planReplayerHandle.deletePlanReplayerStatus(context.Background(), fileName)
 			}
 		}
@@ -159,7 +159,7 @@ func (h *planReplayerHandle) insertExternalPlanReplayerErrorStatusRecord(ctx con
 	exec := h.sctx.(sqlexec.SQLExecutor)
 	_, err := exec.ExecuteInternal(ctx, fmt.Sprintf(
 		"insert into mysql.plan_replayer_status (origin_sql, fail_reason, instance) values ('%s','%s','%s')",
-		record.OriginSql, record.FailedReason, instance))
+		record.OriginSQL, record.FailedReason, instance))
 	if err != nil {
 		logutil.BgLogger().Warn("insert mysql.plan_replayer_status record failed",
 			zap.Error(err))
@@ -172,7 +172,7 @@ func (h *planReplayerHandle) insertExternalPlanReplayerSuccessStatusRecord(ctx c
 	exec := h.sctx.(sqlexec.SQLExecutor)
 	_, err := exec.ExecuteInternal(ctx, fmt.Sprintf(
 		"insert into mysql.plan_replayer_status (origin_sql, token, instance) values ('%s','%s','%s')",
-		record.OriginSql, record.Token, instance))
+		record.OriginSQL, record.Token, instance))
 	if err != nil {
 		logutil.BgLogger().Warn("insert mysql.plan_replayer_status record failed",
 			zap.Error(err))
@@ -182,7 +182,7 @@ func (h *planReplayerHandle) insertExternalPlanReplayerSuccessStatusRecord(ctx c
 // PlanReplayerStatusRecord indicates record in mysql.plan_replayer_status
 type PlanReplayerStatusRecord struct {
 	Internal     bool
-	OriginSql    string
+	OriginSQL    string
 	Token        string
 	FailedReason string
 }
diff --git a/executor/infoschema_cluster_table_test.go b/executor/infoschema_cluster_table_test.go
@@ -290,7 +290,7 @@ func TestTableStorageStats(t *testing.T) {
 		"test 2",
 	))
 	rows := tk.MustQuery("select TABLE_NAME from information_schema.TABLE_STORAGE_STATS where TABLE_SCHEMA = 'mysql';").Rows()
-	result := 37
+	result := 38
 	require.Len(t, rows, result)
 
 	// More tests about the privileges.

diff --git a/executor/plan_replayer.go b/executor/plan_replayer.go
@@ -380,7 +380,7 @@ func generateRecords(task *PlanReplayerDumpTask) []domain.PlanReplayerStatusReco
 	if len(task.ExecStmts) > 0 {
 		for _, execStmt := range task.ExecStmts {
 			records = append(records, domain.PlanReplayerStatusRecord{
-				OriginSql: execStmt.Text(),
+				OriginSQL: execStmt.Text(),
 				Token:     task.FileName,
 				Internal:  false,
 			})