Skip to content

Commit

Permalink
session: Do not run telemetry loops when it's disabled in config (#40156
Browse files Browse the repository at this point in the history
) (#41150)

close #40155
  • Loading branch information
sunxiaoguang authored Mar 30, 2023
1 parent 8b92c83 commit 0cd8c4c
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions session/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -2927,8 +2927,12 @@ func BootstrapSession(store kv.Storage) (*domain.Domain, error) {
if dom.GetEtcdClient() != nil {
// We only want telemetry data in production-like clusters. When TiDB is deployed over other engines,
// for example, unistore engine (used for local tests), we just skip it. Its etcd client is nil.
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
if config.GetGlobalConfig().EnableTelemetry {
// There is no way to turn telemetry on with global variable `tidb_enable_telemetry`
// when it is disabled in config. See IsTelemetryEnabled function in telemetry/telemetry.go
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
}
}

// A sub context for update table stats, and other contexts for concurrent stats loading.
Expand Down

0 comments on commit 0cd8c4c

Please sign in to comment.