Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-binlog: Add RESOLVED as a new binlog type #262

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Aug 13, 2019

What problem does this PR solve?

There's no easy way to differenciate a message containing resolved
timestamp and one that is ordinary binlog.

By adding RESOLVED as a BinlogType and reuse the commit_ts field
for resolved_ts, the consumer can just decode all message as usual and
look out for RESOLVED binlogs.

What is changed and how it works?

  1. Add a third BinlogType: RESOLVED
  2. Regenerate the go file.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

@july2993
Copy link
Contributor

just use your own branch to dev first

@suzaku
Copy link
Contributor Author

suzaku commented Aug 13, 2019

just use your own branch to dev first

👌

@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL
Copy link
Collaborator

@july2993 PTAL

@july2993
Copy link
Contributor

lgtm

@IANTHEREAL
Copy link
Collaborator

/run-all-tests

@july2993 july2993 removed their request for review May 12, 2020 12:04
@ti-chi-bot
Copy link
Member

@suzaku: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ suzaku
❌ IANTHEREAL
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants