-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-binlog: Add RESOLVED as a new binlog type #262
base: master
Are you sure you want to change the base?
Conversation
just use your own branch to dev first |
👌 |
LGTM |
@july2993 PTAL |
lgtm |
/run-all-tests |
@suzaku: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
What problem does this PR solve?
There's no easy way to differenciate a message containing resolved
timestamp and one that is ordinary binlog.
By adding
RESOLVED
as aBinlogType
and reuse thecommit_ts
fieldfor
resolved_ts
, the consumer can just decode all message as usual andlook out for
RESOLVED
binlogs.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes