simplify the if/else logic #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with master
sync with master
remove the redundant parentheses & more
sync with master
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
amyangfei
reviewed
Jan 19, 2019
pkg/diff/merge.go
Outdated
| if strData1 > strData2 { | ||
| return false | ||
| } | ||
| return true | ||
| } else { |
There was a problem hiding this comment.
recommend usage from golint: if block ends with a return statement, so drop this else and outdent its block
|
Good job. Rest LGTM |
|
@amyangfei PTAL |
|
/run-all-tests |
|
LGTM |
|
Thanks @lewgun, @WangXiangUSTC PTAL |
lonng
reviewed
Jan 24, 2019
lonng
reviewed
Jan 25, 2019
WangXiangUSTC
pushed a commit
to WangXiangUSTC/tidb-tools
that referenced
this pull request
Feb 11, 2019
refactor to simplify the if/else logic
WangXiangUSTC
added a commit
that referenced
this pull request
Feb 13, 2019
* sync_diff_inspector: fix a misleading regex example in config.toml (#141) * update pkg about database (#142) * diff: add database name and table name router (#172) * simplify the if/else logic (#179) refactor to simplify the if/else logic * diff: can use multiple columns to split chunks (#130) * simplify the if/else logic (#191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
simplify the if/else logic
What is changed and how it works?
refactor to simplify the if/else logic
Check List
Tests
Code changes
Side effects
Related changes