Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular expression compatible router #600

Closed
buchuitoudegou opened this issue Mar 8, 2022 · 1 comment · Fixed by #601
Closed

Regular expression compatible router #600

buchuitoudegou opened this issue Mar 8, 2022 · 1 comment · Fixed by #601
Labels
type/feature

Comments

@buchuitoudegou
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

ref: pingcap/tiflow#4701

When migrating tables using Lightning, the router in it cannot recognize the regular expression based routing rules while the router in the DM project can do so.

Describe the feature you'd like:

  1. add a new package called regexpr-router to make it compatible across all the projects

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

  1. DM and Lightning can utilize the new router
@buchuitoudegou
Copy link
Contributor Author

I'll file a PR in a minute.

@buchuitoudegou buchuitoudegou mentioned this issue Mar 8, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 9, 2022
@buchuitoudegou
router: regular expression compatible router for DM and Lightning (#601)
935fd45 
close #600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

router: regular expression compatible router for DM and Lightning buchuitoudegou/tidb-tools
1 participant
@buchuitoudegou