-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/manager/member: Fix setting StatefulSet partition bug #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-e2e-in-kind |
/run-e2e-in-kind |
1 similar comment
/run-e2e-in-kind |
/run-e2e-in-kind |
1 similar comment
/run-e2e-in-kind |
/run-e2e-in-kind |
xiaojingchen
changed the title
[WIP]pkg/manager/member: Fix setting StatefulSet partition bug
pkg/manager/member: Fix setting StatefulSet partition bug
Aug 28, 2019
@weekface @shuijing198799 PTAL |
weekface
approved these changes
Sep 3, 2019
cherry pick to release-1.0 in PR #864 |
weekface
pushed a commit
that referenced
this pull request
Sep 3, 2019
onlymellb
pushed a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
this PR fixes: #784
What is changed and how does it work?
Add logic to prevent that TiDB operator setting partition before
statefulSet
'supdateRevision
changed and sync toTidbCluster
Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: