Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extraLabels description in values.yaml #763

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

  • Has documents change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

LinuxGit
LinuxGit previously approved these changes Aug 13, 2019
Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

@tennix PTAL

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface changed the title fix extraLables description in values.yaml fix extraLabels description in values.yaml Aug 22, 2019
@weekface weekface merged commit aaf4e46 into pingcap:master Aug 22, 2019
@weekface weekface deleted the fix-doc branch August 22, 2019 06:23
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

cherry pick to release-1.0 in PR #805

yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants