load cloud provider plugins when using tkctl

[yeya24]

Signed-off-by: yeya24 [email protected]
I' m sorry that I don't have a gcp environment. Can you make a test for this PR? @aylei 😄

What problem does this PR solve?

#721

What is changed and how does it work?

Check List

Tests

• Unit test
• E2E test
• Stability test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has Helm charts change
• Has Go code change
• Has CI related scripts change
• Has documents change

Side effects

• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Does this PR introduce a user-facing change?:

[sre-bot]

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

[sre-bot]

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

[aylei]

/ok-to-test

[aylei]

@yeya24 IMHO, it is better to load all the auth plugins

[yeya24]

OK. Let me recheck it. Do you mean gcp, aws and alicloud? Do I need to add other plugins?

[aylei]

_ "k8s.io/client-go/plugin/pkg/client/auth"

Importing all auth plugins is sufficient I suppose

[yeya24]

Thanks for pointing out this. @aylei Updated, PTAL.

[aylei]

@yeya24
Try to compile tkctl by executing make cli but met the following errors:

# k8s.io/client-go/plugin/pkg/client/auth/azure
../../../../pkg/mod/k8s.io/[email protected]+incompatible/plugin/pkg/client/auth/azure/azure.go:246:4: cannot use expiresIn (type string) as type json.Number in field value
../../../../pkg/mod/k8s.io/[email protected]+incompatible/plugin/pkg/client/auth/azure/azure.go:247:4: cannot use expiresOn (type string) as type json.Number in field value
../../../../pkg/mod/k8s.io/[email protected]+incompatible/plugin/pkg/client/auth/azure/azure.go:248:4: cannot use expiresOn (type string) as type json.Number in field value
../../../../pkg/mod/k8s.io/[email protected]+incompatible/plugin/pkg/client/auth/azure/azure.go:265:23: cannot use token.token.ExpiresIn (type json.Number) as type string in assignment
../../../../pkg/mod/k8s.io/[email protected]+incompatible/plugin/pkg/client/auth/azure/azure.go:266:23: cannot use token.token.ExpiresOn (type json.Number) as type string in assignment
make: *** [cli] Error 2

[tennix]

Remove this empty line.

[yeya24]

Seems in the latest client-go, the code is OK. https://github.com/kubernetes/client-go/blob/4f902818859a531e018f805b2d3597f14bf2c494/plugin/pkg/client/auth/azure/azure.go#L254

	return &azureToken{
		token: adal.Token{
			AccessToken:  accessToken,
			RefreshToken: refreshToken,
			ExpiresIn:    json.Number(expiresIn),
			ExpiresOn:    json.Number(expiresOn),
			NotBefore:    json.Number(expiresOn),

[yeya24]

Seems in the latest client-go, the code is OK. https://github.com/kubernetes/client-go/blob/4f902818859a531e018f805b2d3597f14bf2c494/plugin/pkg/client/auth/azure/azure.go#L254

	return &azureToken{
		token: adal.Token{
			AccessToken:  accessToken,
			RefreshToken: refreshToken,
			ExpiresIn:    json.Number(expiresIn),
			ExpiresOn:    json.Number(expiresOn),
			NotBefore:    json.Number(expiresOn),

After digging into this I found out that this code was fixed in client-go v10.0.0, which is compatible for k8s 1.13+.
If I change go.mod to client-go v10.0.0, it will produce error

build command-line-arguments: cannot load k8s.io/api/admissionregistration/v1alpha1: cannot find module providing package k8s.io/api/admissionregistration/v1alpha1

And the error above can be fixed if we update k8s related package version to 1.13+. See issue kubernetes/client-go#551

Currently we are still using 1.12.5, do we have any plan to update it recently? If not, I think it is better to not add azure auth plugin now.

[aylei]

@yeya24 I'm ok with not importing Azure auth plugin

[yeya24]

Need review for this PR.

[tennix]

LGTM

[aylei]

/run-e2e-tests

[aylei]

/run-e2e-in-kind

[aylei]

/run-e2e-in-kind

[aylei]

LGTM

[aylei]

/run-e2e-in-kind

[aylei]

@yeya24 Thanks!

[sre-bot]

cherry pick to release-1.0 failed