Sets node count for default pool equal to total desired node count to correctly size master #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly size master node
gregwebs
approved these changes
Jul 21, 2019
weekface
pushed a commit
that referenced
this pull request
Jul 29, 2019
)) (cherry picked from commit 21bd6d3)
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add en release notes of v1.1 & v1.0 Signed-off-by: Ran <[email protected]> * add en rn of v0.x; add all zh rn Signed-off-by: Ran <[email protected]> * fix deadlink Signed-off-by: Ran <[email protected]> * fix ci Signed-off-by: Ran <[email protected]> * fix anchor Signed-off-by: Ran <[email protected]> * Update en/releases/release-0.2.1.md * Update zh/releases/release-0.2.1.md * update format and typo Signed-off-by: Ran <[email protected]> * update capitalization of proper nouns Signed-off-by: Ran <[email protected]> Co-authored-by: Lilian Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #615
What is changed and how does it work?
GKE master node is sized initially to expect 5 or fewer nodes when first provisioned, or the size of the default node pool. Previously, the initial node count for the default pool was 1 (3 total because one per availability zone), so when the rest of the node pools get provisioned, GKE would then upgrade the master node to accommodate the rest of the nodes. This change sets the initial node count of the default pool to be equal to the sum of the node counts for the other pools (pd, tikv, tidb, monitor). With this, the master node is correctly sized and does not upgrade shortly after creating the cluster, as it did previously.
Check List
Tests
terraform applyto GKECode changes
Does this PR introduce a user-facing change?: