Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pull request template grammar #607

Merged
merged 1 commit into from
Jun 26, 2019
Merged

fix pull request template grammar #607

merged 1 commit into from
Jun 26, 2019

Conversation

gregwebs
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

@gregwebs gregwebs merged commit 79f91e6 into master Jun 26, 2019
@gregwebs gregwebs deleted the pull-request-template-grammar branch June 26, 2019 21:39
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang
en: fix aliases in get-started (#607)
08c6d62 
Signed-off-by: Ran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregwebs @weekface @cofyc