New crd for log compact #5822
New crd for log compact #5822
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… secret …" (pingcap#5823) This reverts commit 8cb0848.
Signed-off-by: hillium <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5822 +/- ##
==========================================
- Coverage 57.19% 56.09% -1.10%
==========================================
Files 259 266 +7
Lines 33233 45744 +12511
==========================================
+ Hits 19008 25661 +6653
- Misses 12291 18098 +5807
- Partials 1934 1985 +51
|
|
/retest |
| } | ||
| return errors.Errorf("until-ts %d must be greater than from-ts %d", c.UntilTS, c.FromTS) | ||
| } | ||
| if c.Concurrency <= 0 { |
There was a problem hiding this comment.
you can set a default concurrency here.
There was a problem hiding this comment.
maybe,but not here, I prefer to set it in types.go
|
|
||
| //Skip | ||
| if backup.Status.State != "" { | ||
| return nil |
There was a problem hiding this comment.
you can't just return here. if the CompactBackup is in prepare status, but creating job failed and updating failed status failed, how to handle that? Besides that, if create job failed, it is better to retry.
There was a problem hiding this comment.
ok, Now I will check if the job is already running and sync the job state to CR if it failed
Co-authored-by: WangLe1321 <[email protected]>
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.