-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/aws: update AWS deploy docs after testing #491
Merged
AstroProfundis
merged 7 commits into
pingcap:master
from
AstroProfundis:update-docs-aws
May 15, 2019
Merged
docs/aws: update AWS deploy docs after testing #491
AstroProfundis
merged 7 commits into
pingcap:master
from
AstroProfundis:update-docs-aws
May 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlerche
previously approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lilin90
reviewed
May 15, 2019
Co-Authored-By: Lilian Lee <[email protected]>
Co-Authored-By: Lilian Lee <[email protected]>
lilin90
reviewed
May 15, 2019
Co-Authored-By: Lilian Lee <[email protected]>
lilin90
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Testing current documentation of deploying TiDB Operator on AWS with Terraform and keep it up to date.
What is changed and how it works?
Tested all instructions in the AWS installation documentation on a VM with latest ArchLinux, updated them to fit testing results and added some detailed notes.
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: