add slack notify #439
Merged
add slack notify #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
requested review from
weekface,
shuijing198799 and
tennix
and removed request for
weekface
|
/run-e2e-tests |
weekface
previously approved these changes
May 1, 2019
tests/pkg/webhook/pods.go
Outdated
| reviewResponse.Allowed = true | ||
| return &reviewResponse | ||
| } | ||
|
|
There was a problem hiding this comment.
Why did you move this logic into tidb only. this is a common logic for tidb tikv and pd.
|
fixed some bugs @shuijing198799 @weekface PTAL |
1 similar comment
|
fixed some bugs @shuijing198799 @weekface PTAL |
|
/run-e2e-tests |
weekface
approved these changes
May 5, 2019
|
/run-e2e-tests |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Co-authored-by: DanielZhangQD <[email protected]> Co-authored-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
solve the problem that stability test lack notify feature
What is changed and how it works?
this pr will notify the particular slack channel when stability test failed or complete
Check List
Tests
Code changes